Skip to content
Snippets Groups Projects

Change systemd service & context path

Merged Guillaume Cornut requested to merge chore/dd_systemd_gpds_path into master
All threads resolved!

TODO: Change context path in CI/CD env variables

Merge request reports

Checking pipeline status.

Approval is optional

Merged by Raphaël FloresRaphaël Flores 6 years ago (Feb 28, 2019 8:54am UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Not directly related to this MR but this line: https://forgemia.inra.fr/urgi-is/gpds/blob/b0938a2bbee5234f4791c1e87b1974398b4473cf/.gitlab-ci.yml#L42

    Is --parellel really neccessary for only testing frontend code?

  • Also, we had a discussion about moving the public/private part at the end of the ENV variable here: https://forgemia.inra.fr/urgi-is/gpds/blob/b0938a2bbee5234f4791c1e87b1974398b4473cf/.gitlab-ci.yml#L187 and here https://forgemia.inra.fr/urgi-is/gpds/blob/b0938a2bbee5234f4791c1e87b1974398b4473cf/.gitlab-ci.yml#L169

    I find it more comprehensive since the second part of the ENV would always be beta/int/staging/prod and only the 3rd part (if existing) would refer to the confidentiality status.

    Don't remember if a decision was clearly made. Any remark about moving them at the end?

  • Is --parellel really neccessary for only testing frontend code?

    Not really but if one day we have more than one gradle task in :frontend:test then they will be run in parallel ^^

  • added 1 commit

    • 26dc6b1b - fix: Update GPDS prod public/private ENV names.

    Compare with previous version

  • Raphaël Flores resolved all discussions

    resolved all discussions

  • Raphaël Flores enabled an automatic merge when the pipeline for 26dc6b1b succeeds

    enabled an automatic merge when the pipeline for 26dc6b1b succeeds

  • Raphaël Flores mentioned in commit 0c354b9f

    mentioned in commit 0c354b9f

  • Please register or sign in to reply
    Loading